Skip to content

Commit 4448779

Browse files
committed
clk: renesas: r8a7779: Remove struct r8a7779_cpg
All but the data member of the r8a7779_cpg structure are unused, so the whole structure can be replaced by the single member used. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Link: https://lore.kernel.org/r/eb94c0f6c54a4f3a7e0e07f12781333a700c0a05.1654694831.git.geert+renesas@glider.be
1 parent 1cfeec2 commit 4448779

1 file changed

Lines changed: 9 additions & 18 deletions

File tree

drivers/clk/renesas/clk-r8a7779.c

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,6 @@
2121

2222
#define CPG_NUM_CLOCKS (R8A7779_CLK_OUT + 1)
2323

24-
struct r8a7779_cpg {
25-
struct clk_onecell_data data;
26-
spinlock_t lock;
27-
void __iomem *reg;
28-
};
29-
3024
/* -----------------------------------------------------------------------------
3125
* CPG Clock Data
3226
*/
@@ -87,7 +81,7 @@ static const unsigned int cpg_plla_mult[4] __initconst = { 42, 48, 56, 64 };
8781
*/
8882

8983
static struct clk * __init
90-
r8a7779_cpg_register_clock(struct device_node *np, struct r8a7779_cpg *cpg,
84+
r8a7779_cpg_register_clock(struct device_node *np,
9185
const struct cpg_clk_config *config,
9286
unsigned int plla_mult, const char *name)
9387
{
@@ -119,7 +113,7 @@ r8a7779_cpg_register_clock(struct device_node *np, struct r8a7779_cpg *cpg,
119113
static void __init r8a7779_cpg_clocks_init(struct device_node *np)
120114
{
121115
const struct cpg_clk_config *config;
122-
struct r8a7779_cpg *cpg;
116+
struct clk_onecell_data *data;
123117
struct clk **clks;
124118
unsigned int i, plla_mult;
125119
int num_clks;
@@ -134,19 +128,17 @@ static void __init r8a7779_cpg_clocks_init(struct device_node *np)
134128
return;
135129
}
136130

137-
cpg = kzalloc(sizeof(*cpg), GFP_KERNEL);
131+
data = kzalloc(sizeof(*data), GFP_KERNEL);
138132
clks = kcalloc(CPG_NUM_CLOCKS, sizeof(*clks), GFP_KERNEL);
139-
if (cpg == NULL || clks == NULL) {
133+
if (data == NULL || clks == NULL) {
140134
/* We're leaking memory on purpose, there's no point in cleaning
141135
* up as the system won't boot anyway.
142136
*/
143137
return;
144138
}
145139

146-
spin_lock_init(&cpg->lock);
147-
148-
cpg->data.clks = clks;
149-
cpg->data.clk_num = num_clks;
140+
data->clks = clks;
141+
data->clk_num = num_clks;
150142

151143
config = &cpg_clk_configs[CPG_CLK_CONFIG_INDEX(mode)];
152144
plla_mult = cpg_plla_mult[CPG_PLLA_MULT_INDEX(mode)];
@@ -158,16 +150,15 @@ static void __init r8a7779_cpg_clocks_init(struct device_node *np)
158150
of_property_read_string_index(np, "clock-output-names", i,
159151
&name);
160152

161-
clk = r8a7779_cpg_register_clock(np, cpg, config,
162-
plla_mult, name);
153+
clk = r8a7779_cpg_register_clock(np, config, plla_mult, name);
163154
if (IS_ERR(clk))
164155
pr_err("%s: failed to register %pOFn %s clock (%ld)\n",
165156
__func__, np, name, PTR_ERR(clk));
166157
else
167-
cpg->data.clks[i] = clk;
158+
data->clks[i] = clk;
168159
}
169160

170-
of_clk_add_provider(np, of_clk_src_onecell_get, &cpg->data);
161+
of_clk_add_provider(np, of_clk_src_onecell_get, data);
171162

172163
cpg_mstp_add_clk_domain(np);
173164
}

0 commit comments

Comments
 (0)