Skip to content

Commit 451f0b6

Browse files
Christoph Hellwigaxboe
authored andcommitted
block: default BLOCK_LEGACY_AUTOLOAD to y
As Luis reported, losetup currently doesn't properly create the loop device without this if the device node already exists because old scripts created it manually. So default to y for now and remove the aggressive removal schedule. Reported-by: Luis Chamberlain <mcgrof@kernel.org> Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> Link: https://lore.kernel.org/r/20220225181440.1351591-1-hch@lst.de Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 86d7331 commit 451f0b6

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

block/Kconfig

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,13 @@ if BLOCK
2828

2929
config BLOCK_LEGACY_AUTOLOAD
3030
bool "Legacy autoloading support"
31+
default y
3132
help
3233
Enable loading modules and creating block device instances based on
3334
accesses through their device special file. This is a historic Linux
3435
feature and makes no sense in a udev world where device files are
35-
created on demand.
36-
37-
Say N here unless booting or other functionality broke without it, in
38-
which case you should also send a report to your distribution and
39-
linux-block@vger.kernel.org.
36+
created on demand, but scripts that manually create device nodes and
37+
then call losetup might rely on this behavior.
4038

4139
config BLK_RQ_ALLOC_TIME
4240
bool

block/bdev.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -738,7 +738,7 @@ struct block_device *blkdev_get_no_open(dev_t dev)
738738
inode = ilookup(blockdev_superblock, dev);
739739
if (inode)
740740
pr_warn_ratelimited(
741-
"block device autoloading is deprecated. It will be removed in Linux 5.19\n");
741+
"block device autoloading is deprecated and will be removed.\n");
742742
}
743743
if (!inode)
744744
return NULL;

0 commit comments

Comments
 (0)