NFS: Memory allocation failures are not server fatal errors

Trond Myklebust · amschuma-ntap · commit 452284407c18 · 2022-05-17T12:53:33.000-04:00
We need to filter out ENOMEM in nfs_error_is_fatal_on_server(), because running out of memory on our client is not a server error. Reported-by: Olga Kornievskaia <aglo@umich.edu> Fixes: 2dc23af ("NFS: ENOMEM should also be a fatal error.") Cc: stable@vger.kernel.org Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h
@@ -841,6 +841,7 @@ static inline bool nfs_error_is_fatal_on_server(int err)
 	case 0:
 	case -ERESTARTSYS:
 	case -EINTR:
+	case -ENOMEM:
 		return false;
 	}
 	return nfs_error_is_fatal(err);

Original file line number	Diff line number	Diff line change
`@@ -841,6 +841,7 @@ static inline bool nfs_error_is_fatal_on_server(int err)`
`841`	`841`	`case 0:`
`842`	`842`	`case -ERESTARTSYS:`
`843`	`843`	`case -EINTR:`
	`844`	`+ case -ENOMEM:`
`844`	`845`	`return false;`
`845`	`846`	`}`
`846`	`847`	`return nfs_error_is_fatal(err);`