Skip to content

Commit 45733d2

Browse files
committed
fbdev: Remove FBINFO_DEFAULT from devm_kzalloc()'ed structs
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by devm_kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v4: * clarify commit message (Geert, Dan) v2: * fix commit message (Miguel) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Sam Ravnborg <sam@ravnborg.org> Cc: Helge Deller <deller@gmx.de> Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-5-tzimmermann@suse.de
1 parent a0331a4 commit 45733d2

4 files changed

Lines changed: 1 addition & 5 deletions

File tree

drivers/video/fbdev/pxafb.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1826,7 +1826,6 @@ static struct pxafb_info *pxafb_init_fbinfo(struct device *dev,
18261826
fbi->fb.var.vmode = FB_VMODE_NONINTERLACED;
18271827

18281828
fbi->fb.fbops = &pxafb_ops;
1829-
fbi->fb.flags = FBINFO_DEFAULT;
18301829
fbi->fb.node = -1;
18311830

18321831
addr = fbi;

drivers/video/fbdev/sa1100fb.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1089,7 +1089,6 @@ static struct sa1100fb_info *sa1100fb_init_fbinfo(struct device *dev)
10891089
fbi->fb.var.vmode = FB_VMODE_NONINTERLACED;
10901090

10911091
fbi->fb.fbops = &sa1100fb_ops;
1092-
fbi->fb.flags = FBINFO_DEFAULT;
10931092
fbi->fb.monspecs = monspecs;
10941093
fbi->fb.pseudo_palette = fbi->pseudo_palette;
10951094

drivers/video/fbdev/wm8505fb.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,8 +285,7 @@ static int wm8505fb_probe(struct platform_device *pdev)
285285
fbi->fb.fix.accel = FB_ACCEL_NONE;
286286

287287
fbi->fb.fbops = &wm8505fb_ops;
288-
fbi->fb.flags = FBINFO_DEFAULT
289-
| FBINFO_HWACCEL_COPYAREA
288+
fbi->fb.flags = FBINFO_HWACCEL_COPYAREA
290289
| FBINFO_HWACCEL_FILLRECT
291290
| FBINFO_HWACCEL_XPAN
292291
| FBINFO_HWACCEL_YPAN

drivers/video/fbdev/xilinxfb.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,6 @@ static int xilinxfb_assign(struct platform_device *pdev,
324324
drvdata->info.fix.line_length = pdata->xvirt * BYTES_PER_PIXEL;
325325

326326
drvdata->info.pseudo_palette = drvdata->pseudo_palette;
327-
drvdata->info.flags = FBINFO_DEFAULT;
328327
drvdata->info.var = xilinx_fb_var;
329328
drvdata->info.var.height = pdata->screen_height_mm;
330329
drvdata->info.var.width = pdata->screen_width_mm;

0 commit comments

Comments
 (0)