Skip to content

Commit 45ae16e

Browse files
committed
platform/x86: x86-android-tablets: Fix Lenovo Yoga Tablet 2 830F/L vs 1050F/L detection
gpio_crystalcove pin 10 is already in input mode and passing GPIOD_IN when requesting the GPIO changes its pull-up/-down settings causing the 830F/L to get misdetected as 1050F/L. Switch to using GPIOD_ASIS when requesting the GPIO to fix the misdetection. Fixes: 4014ae2 ("platform/x86: x86-android-tablets: Stop using gpiolib private APIs") Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20230915214933.62595-1-hdegoede@redhat.com
1 parent 318d978 commit 45ae16e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • drivers/platform/x86/x86-android-tablets

drivers/platform/x86/x86-android-tablets/lenovo.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ static int __init lenovo_yoga_tab2_830_1050_init_touchscreen(void)
436436

437437
/* Use PMIC GPIO 10 bootstrap pin to differentiate 830 vs 1050 */
438438
ret = x86_android_tablet_get_gpiod("gpio_crystalcove", 10, "yoga_bootstrap",
439-
false, GPIOD_IN, &gpiod);
439+
false, GPIOD_ASIS, &gpiod);
440440
if (ret)
441441
return ret;
442442

0 commit comments

Comments
 (0)