Skip to content

Commit 462baaf

Browse files
konradybcioGeorgi Djakov
authored andcommitted
dt-bindings: interconnect: qcom: Fix and separate out MSM8939
Separate out MSM8939 icc bindings from the common file and fix the clocks description by removing the wrong internal RPM bus clock representation that we've been carrying for years. This was the final one, so also retire the shared file. Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Link: https://lore.kernel.org/r/20230721-topic-icc_bindings-v2-5-e33d5acbf3bd@linaro.org Signed-off-by: Georgi Djakov <djakov@kernel.org>
1 parent d03374a commit 462baaf

2 files changed

Lines changed: 74 additions & 49 deletions

File tree

Lines changed: 74 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,74 @@
1+
# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
2+
%YAML 1.2
3+
---
4+
$id: http://devicetree.org/schemas/interconnect/qcom,msm8939.yaml#
5+
$schema: http://devicetree.org/meta-schemas/core.yaml#
6+
7+
title: Qualcomm MSM8939 Network-On-Chip interconnect
8+
9+
maintainers:
10+
- Konrad Dybcio <konradybcio@kernel.org>
11+
12+
description: |
13+
The Qualcomm MSM8939 interconnect providers support adjusting the
14+
bandwidth requirements between the various NoC fabrics.
15+
16+
allOf:
17+
- $ref: qcom,rpm-common.yaml#
18+
19+
properties:
20+
compatible:
21+
enum:
22+
- qcom,msm8939-bimc
23+
- qcom,msm8939-pcnoc
24+
- qcom,msm8939-snoc
25+
26+
reg:
27+
maxItems: 1
28+
29+
patternProperties:
30+
'^interconnect-[a-z0-9\-]+$':
31+
type: object
32+
$ref: qcom,rpm-common.yaml#
33+
description:
34+
The interconnect providers do not have a separate QoS register space,
35+
but share parent's space.
36+
37+
allOf:
38+
- $ref: qcom,rpm-common.yaml#
39+
40+
properties:
41+
compatible:
42+
const: qcom,msm8939-snoc-mm
43+
44+
required:
45+
- compatible
46+
47+
unevaluatedProperties: false
48+
49+
required:
50+
- compatible
51+
- reg
52+
53+
unevaluatedProperties: false
54+
55+
examples:
56+
- |
57+
#include <dt-bindings/clock/qcom,rpmcc.h>
58+
59+
snoc: interconnect@580000 {
60+
compatible = "qcom,msm8939-snoc";
61+
reg = <0x00580000 0x14000>;
62+
#interconnect-cells = <1>;
63+
};
64+
65+
bimc: interconnect@400000 {
66+
compatible = "qcom,msm8939-bimc";
67+
reg = <0x00400000 0x62000>;
68+
#interconnect-cells = <1>;
69+
70+
snoc_mm: interconnect-snoc {
71+
compatible = "qcom,msm8939-snoc-mm";
72+
#interconnect-cells = <1>;
73+
};
74+
};

Documentation/devicetree/bindings/interconnect/qcom,rpm.yaml

Lines changed: 0 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ properties:
2323
- qcom,msm8916-bimc
2424
- qcom,msm8916-pcnoc
2525
- qcom,msm8916-snoc
26-
- qcom,msm8939-bimc
27-
- qcom,msm8939-pcnoc
28-
- qcom,msm8939-snoc
2926
- qcom,qcs404-bimc
3027
- qcom,qcs404-pcnoc
3128
- qcom,qcs404-snoc
@@ -48,38 +45,6 @@ properties:
4845
power-domains:
4946
maxItems: 1
5047

51-
# Child node's properties
52-
patternProperties:
53-
'^interconnect-[a-z0-9]+$':
54-
type: object
55-
additionalProperties: false
56-
description:
57-
snoc-mm is a child of snoc, sharing snoc's register address space.
58-
59-
properties:
60-
compatible:
61-
enum:
62-
- qcom,msm8939-snoc-mm
63-
64-
'#interconnect-cells':
65-
const: 1
66-
67-
clock-names:
68-
items:
69-
- const: bus
70-
- const: bus_a
71-
72-
clocks:
73-
items:
74-
- description: Bus Clock
75-
- description: Bus A Clock
76-
77-
required:
78-
- compatible
79-
- '#interconnect-cells'
80-
- clock-names
81-
- clocks
82-
8348
required:
8449
- compatible
8550
- reg
@@ -98,9 +63,6 @@ allOf:
9863
- qcom,msm8916-bimc
9964
- qcom,msm8916-pcnoc
10065
- qcom,msm8916-snoc
101-
- qcom,msm8939-bimc
102-
- qcom,msm8939-pcnoc
103-
- qcom,msm8939-snoc
10466
- qcom,qcs404-bimc
10567
- qcom,qcs404-pcnoc
10668
- qcom,qcs404-snoc
@@ -117,17 +79,6 @@ allOf:
11779
- description: Bus Clock
11880
- description: Bus A Clock
11981

120-
- if:
121-
not:
122-
properties:
123-
compatible:
124-
contains:
125-
enum:
126-
- qcom,msm8939-snoc
127-
then:
128-
patternProperties:
129-
'^interconnect-[a-z0-9]+$': false
130-
13182
examples:
13283
- |
13384
#include <dt-bindings/clock/qcom,rpmcc.h>

0 commit comments

Comments
 (0)