Skip to content

Commit 463b97b

Browse files
committed
clk: bm1880: convert from divider_round_rate() to divider_determine_rate()
The divider_round_rate() function is now deprecated, so let's migrate to divider_determine_rate() instead so that this deprecated API can be removed. Note that when the main function itself was migrated to use determine_rate, this was mistakenly converted to: req->rate = divider_round_rate(...) This is invalid in the case when an error occurs since it can set the rate to a negative value. Fixes: 64613d7 ("clk: bm1880: convert from round_rate() to determine_rate()") Acked-by: Manivannan Sadhasivam <mani@kernel.org> Signed-off-by: Brian Masney <bmasney@redhat.com>
1 parent 7468ac0 commit 463b97b

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

drivers/clk/clk-bm1880.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -625,10 +625,7 @@ static int bm1880_clk_div_determine_rate(struct clk_hw *hw,
625625
div->width, div->flags, val);
626626
}
627627

628-
req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate,
629-
div->table, div->width, div->flags);
630-
631-
return 0;
628+
return divider_determine_rate(hw, req, div->table, div->width, div->flags);
632629
}
633630

634631
static int bm1880_clk_div_set_rate(struct clk_hw *hw, unsigned long rate,

0 commit comments

Comments
 (0)