Skip to content

Commit 4644736

Browse files
committed
io_uring/cmd_net: fix wrong argument types for skb_queue_splice()
If timestamp retriving needs to be retried and the local list of SKB's already has entries, then it's spliced back into the socket queue. However, the arguments for the splice helper are transposed, causing exactly the wrong direction of splicing into the on-stack list. Fix that up. Cc: stable@vger.kernel.org Reported-by: Google Big Sleep <big-sleep-vuln-reports+bigsleep-462435176@google.com> Fixes: 9e4ed35 ("io_uring/netcmd: add tx timestamping cmd support") Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 2d0e88f commit 4644736

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

io_uring/cmd_net.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ static int io_uring_cmd_timestamp(struct socket *sock,
127127

128128
if (!unlikely(skb_queue_empty(&list))) {
129129
scoped_guard(spinlock_irqsave, &q->lock)
130-
skb_queue_splice(q, &list);
130+
skb_queue_splice(&list, q);
131131
}
132132
return -EAGAIN;
133133
}

0 commit comments

Comments
 (0)