Skip to content

Commit 46a16d8

Browse files
jhovoldbroonie
authored andcommitted
ASoC: codecs: wsa883x: suppress variant printk
Drivers should generally be silent on successful probe. Demote the codec variant printk to debug level and instead add a warning in case an unknown variant is ever encountered. Signed-off-by: Johan Hovold <johan@kernel.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com> Link: https://patch.msgid.link/20260102111413.9605-5-johan@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 120f3e6 commit 46a16d8

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

sound/soc/codecs/wsa883x.c

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1058,22 +1058,23 @@ static int wsa883x_init(struct wsa883x_priv *wsa883x)
10581058

10591059
switch (variant) {
10601060
case WSA8830:
1061-
dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8830\n",
1062-
version);
1061+
dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8830\n",
1062+
version);
10631063
break;
10641064
case WSA8835:
1065-
dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835\n",
1066-
version);
1065+
dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835\n",
1066+
version);
10671067
break;
10681068
case WSA8832:
1069-
dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8832\n",
1070-
version);
1069+
dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8832\n",
1070+
version);
10711071
break;
10721072
case WSA8835_V2:
1073-
dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835_V2\n",
1074-
version);
1073+
dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835_V2\n",
1074+
version);
10751075
break;
10761076
default:
1077+
dev_warn(wsa883x->dev, "unknown variant: %d\n", variant);
10771078
break;
10781079
}
10791080

0 commit comments

Comments
 (0)