Skip to content

Commit 46f99ee

Browse files
cyndisthierryreding
authored andcommitted
drm/tegra: Don't call SET_APPLICATION_ID in VIC boot
The application should be programming the application ID, not the kernel, as there can be several options to choose from, and setting the application ID multiple times can cause issues. Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> Signed-off-by: Thierry Reding <treding@nvidia.com>
1 parent d12919b commit 46f99ee

2 files changed

Lines changed: 0 additions & 3 deletions

File tree

drivers/gpu/drm/tegra/vic.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,6 @@ static int vic_boot(struct vic *vic)
148148
hdr = vic->falcon.firmware.virt;
149149
fce_bin_data_offset = *(u32 *)(hdr + VIC_UCODE_FCE_DATA_OFFSET);
150150

151-
falcon_execute_method(&vic->falcon, VIC_SET_APPLICATION_ID, 1);
152-
153151
/* Old VIC firmware needs kernel help with setting up FCE microcode. */
154152
if (fce_bin_data_offset != 0x0 && fce_bin_data_offset != 0xa5a5a5a5) {
155153
hdr = vic->falcon.firmware.virt +

drivers/gpu/drm/tegra/vic.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
/* VIC methods */
1010

11-
#define VIC_SET_APPLICATION_ID 0x00000200
1211
#define VIC_SET_FCE_UCODE_SIZE 0x0000071C
1312
#define VIC_SET_FCE_UCODE_OFFSET 0x0000072C
1413

0 commit comments

Comments
 (0)