Skip to content

Commit 4721007

Browse files
krzkGeorgi Djakov
authored andcommitted
dt-bindings: interconnect: qcom,sa8775p-rpmh: Fix incorrectly added reg and clocks
Commit 8a55fbe ("dt-bindings: interconnect: add reg and clocks properties to enable QoS on sa8775p") claims that all interconnects have clocks and MMIO address space, but that is just not true. Only few have. Bindings should restrict properties and should not allow specifying non-existing hardware description, so fix missing constraints for 'reg' and 'clocks'. Fixes: 8a55fbe ("dt-bindings: interconnect: add reg and clocks properties to enable QoS on sa8775p") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Acked-by: Rob Herring (Arm) <robh@kernel.org> Link: https://lore.kernel.org/r/20251129094612.16838-2-krzysztof.kozlowski@oss.qualcomm.com Signed-off-by: Georgi Djakov <djakov@kernel.org>
1 parent 8f0b4cc commit 4721007

1 file changed

Lines changed: 31 additions & 0 deletions

File tree

Documentation/devicetree/bindings/interconnect/qcom,sa8775p-rpmh.yaml

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,37 @@ allOf:
7474
- description: aggre UFS CARD AXI clock
7575
- description: RPMH CC IPA clock
7676

77+
- if:
78+
properties:
79+
compatible:
80+
contains:
81+
enum:
82+
- qcom,sa8775p-config-noc
83+
- qcom,sa8775p-dc-noc
84+
- qcom,sa8775p-gem-noc
85+
- qcom,sa8775p-gpdsp-anoc
86+
- qcom,sa8775p-lpass-ag-noc
87+
- qcom,sa8775p-mmss-noc
88+
- qcom,sa8775p-nspa-noc
89+
- qcom,sa8775p-nspb-noc
90+
- qcom,sa8775p-pcie-anoc
91+
- qcom,sa8775p-system-noc
92+
then:
93+
properties:
94+
clocks: false
95+
96+
- if:
97+
properties:
98+
compatible:
99+
contains:
100+
enum:
101+
- qcom,sa8775p-clk-virt
102+
- qcom,sa8775p-mc-virt
103+
then:
104+
properties:
105+
reg: false
106+
clocks: false
107+
77108
unevaluatedProperties: false
78109

79110
examples:

0 commit comments

Comments
 (0)