Skip to content

Commit 4728e3f

Browse files
djrscallyvinodkoul
authored andcommitted
dmaengine: pl330: Clear callback_result for re-used descs
The pl330 driver re-uses DMA descriptors rather than reallocating them each time. At present, upon re-use the .callback member is cleared, but .callback result is not. This causes problems where a consuming driver sets the .callback_result for some submissions but not for others, as eventually the function is invoked erronously. Clear .callback_result along with .callback Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> Link: https://lore.kernel.org/r/20240118112959.1027471-1-dan.scally@ideasonboard.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 6613476 commit 4728e3f

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/dma/pl330.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2588,6 +2588,7 @@ static struct dma_pl330_desc *pluck_desc(struct list_head *pool,
25882588

25892589
desc->status = PREP;
25902590
desc->txd.callback = NULL;
2591+
desc->txd.callback_result = NULL;
25912592
}
25922593

25932594
spin_unlock_irqrestore(lock, flags);

0 commit comments

Comments
 (0)