Skip to content

Commit 479972e

Browse files
Pingfan LiuPeter Zijlstra
authored andcommitted
sched/deadline: Remove unnecessary comment in dl_add_task_root_domain()
The comments above dl_get_task_effective_cpus() and dl_add_task_root_domain() already explain how to fetch a valid root domain and protect against races. There's no need to repeat this inside dl_add_task_root_domain(). Remove the redundant comment to keep the code clean. No functional change. Signed-off-by: Pingfan Liu <piliu@redhat.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Acked-by: Juri Lelli <juri.lelli@redhat.com> Acked-by: Waiman Long <longman@redhat.com> Link: https://patch.msgid.link/20251125032630.8746-2-piliu@redhat.com
1 parent 0f61b18 commit 479972e

1 file changed

Lines changed: 0 additions & 9 deletions

File tree

kernel/sched/deadline.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3162,20 +3162,11 @@ void dl_add_task_root_domain(struct task_struct *p)
31623162
return;
31633163
}
31643164

3165-
/*
3166-
* Get an active rq, whose rq->rd traces the correct root
3167-
* domain.
3168-
* Ideally this would be under cpuset reader lock until rq->rd is
3169-
* fetched. However, sleepable locks cannot nest inside pi_lock, so we
3170-
* rely on the caller of dl_add_task_root_domain() holds 'cpuset_mutex'
3171-
* to guarantee the CPU stays in the cpuset.
3172-
*/
31733165
dl_get_task_effective_cpus(p, msk);
31743166
cpu = cpumask_first_and(cpu_active_mask, msk);
31753167
BUG_ON(cpu >= nr_cpu_ids);
31763168
rq = cpu_rq(cpu);
31773169
dl_b = &rq->rd->dl_bw;
3178-
/* End of fetching rd */
31793170

31803171
raw_spin_lock(&dl_b->lock);
31813172
__dl_add(dl_b, p->dl.dl_bw, cpumask_weight(rq->rd->span));

0 commit comments

Comments
 (0)