Skip to content

Commit 47fa0fa

Browse files
geertuhdeller
authored andcommitted
fbdev: sh_mobile_lcdcfb: Fix ARGB32 overlay format typo
When configurating a CHn Source Image Format Register (LDBBSIFR), one should use the corresponding LDBBSIFR_RPKF_* definition for overlay planes, not the DDFR_PKF_* definition for the primary plane. Fortunately both definitions resolve to the same value, so this bug did not cause any harm. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent dadeeff commit 47fa0fa

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/video/fbdev/sh_mobile_lcdcfb.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -824,7 +824,7 @@ static void sh_mobile_lcdc_overlay_setup(struct sh_mobile_lcdc_overlay *ovl)
824824
format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDBBSIFR_RPKF_RGB24;
825825
break;
826826
case V4L2_PIX_FMT_BGR32:
827-
format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDDFR_PKF_ARGB32;
827+
format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDBBSIFR_RPKF_ARGB32;
828828
break;
829829
case V4L2_PIX_FMT_NV12:
830830
case V4L2_PIX_FMT_NV21:

0 commit comments

Comments
 (0)