Input: alps - remove redundant assignment to variable ret

Colin Ian King · dtor · commit 47fcd0f969e9 · 2020-08-06T17:33:41.000-07:00
The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King <colin.king@canonical.com> Link: https://lore.kernel.org/r/20200603135742.130852-1-colin.king@canonical.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
@@ -1929,7 +1929,7 @@ static int alps_monitor_mode(struct psmouse *psmouse, bool enable)
 static int alps_absolute_mode_v6(struct psmouse *psmouse)
 {
 	u16 reg_val = 0x181;
-	int ret = -1;
+	int ret;
 
 	/* enter monitor mode, to write the register */
 	if (alps_monitor_mode(psmouse, true))

Original file line number	Diff line number	Diff line change
`@@ -1929,7 +1929,7 @@ static int alps_monitor_mode(struct psmouse *psmouse, bool enable)`
`1929`	`1929`	`static int alps_absolute_mode_v6(struct psmouse *psmouse)`
`1930`	`1930`	`{`
`1931`	`1931`	`u16 reg_val = 0x181;`
`1932`		`- int ret = -1;`
	`1932`	`+ int ret;`
`1933`	`1933`
`1934`	`1934`	`/* enter monitor mode, to write the register */`
`1935`	`1935`	`if (alps_monitor_mode(psmouse, true))`