Skip to content

Commit 48634a9

Browse files
committed
drm/msm: Adjust msm_iommu_pagetable_prealloc_allocate() allocation type
In preparation for making the kmalloc family of allocators type aware, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (Before, the allocator would always return "void *", which can be implicitly cast to any pointer type.) The assigned type is "void **" but the returned type will be "void ***". These are the same allocation size (pointer size), but the types do not match. Adjust the allocation type to match the assignment. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Link: https://patch.msgid.link/20260206222151.work.016-kees@kernel.org Signed-off-by: Kees Cook <kees@kernel.org>
1 parent a3fab95 commit 48634a9

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/msm/msm_iommu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ msm_iommu_pagetable_prealloc_allocate(struct msm_mmu *mmu, struct msm_mmu_preall
332332
struct kmem_cache *pt_cache = get_pt_cache(mmu);
333333
int ret;
334334

335-
p->pages = kvmalloc_array(p->count, sizeof(p->pages), GFP_KERNEL);
335+
p->pages = kvmalloc_array(p->count, sizeof(*p->pages), GFP_KERNEL);
336336
if (!p->pages)
337337
return -ENOMEM;
338338

0 commit comments

Comments
 (0)