Skip to content

Commit 489bfc5

Browse files
paliLorenzo Pieralisi
authored andcommitted
PCI: mvebu: Check that PCI bridge specified in DT has function number zero
Driver cannot handle PCI bridges at non-zero function address. So add appropriate check. Currently all in-tree kernel DTS files set PCI bridge function to zero. Link: https://lore.kernel.org/r/20211125124605.25915-4-pali@kernel.org Signed-off-by: Pali Rohár <pali@kernel.org> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
1 parent 5d18d70 commit 489bfc5

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

drivers/pci/controller/pci-mvebu.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -845,6 +845,11 @@ static int mvebu_pcie_parse_port(struct mvebu_pcie *pcie,
845845
port->devfn = of_pci_get_devfn(child);
846846
if (port->devfn < 0)
847847
goto skip;
848+
if (PCI_FUNC(port->devfn) != 0) {
849+
dev_err(dev, "%s: invalid function number, must be zero\n",
850+
port->name);
851+
goto skip;
852+
}
848853

849854
ret = mvebu_get_tgt_attr(dev->of_node, port->devfn, IORESOURCE_MEM,
850855
&port->mem_target, &port->mem_attr);

0 commit comments

Comments
 (0)