Skip to content

Commit 496daa2

Browse files
Chen Nilucaceresoli
authored andcommitted
drm/bridge: synopsys: dw-dp: Check return value of devm_drm_bridge_add() in dw_dp_bind()
Return the value of devm_drm_bridge_add() in order to propagate the error properly, if it fails due to resource allocation failure or bridge registration failure. This ensures that the bind function fails safely rather than proceeding with a potentially incomplete bridge setup. Fixes: b726970 ("drm/bridge: synopsys: dw-dp: add bridge before attaching") Signed-off-by: Chen Ni <nichen@iscas.ac.cn> Reviewed-by: Andy Yan <andyshrk@163.com> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Link: https://patch.msgid.link/20260206040621.4095517-1-nichen@iscas.ac.cn Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
1 parent c5f8658 commit 496daa2

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

  • drivers/gpu/drm/bridge/synopsys

drivers/gpu/drm/bridge/synopsys/dw-dp.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2049,7 +2049,9 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder,
20492049
bridge->type = DRM_MODE_CONNECTOR_DisplayPort;
20502050
bridge->ycbcr_420_allowed = true;
20512051

2052-
devm_drm_bridge_add(dev, bridge);
2052+
ret = devm_drm_bridge_add(dev, bridge);
2053+
if (ret)
2054+
return ERR_PTR(ret);
20532055

20542056
dp->aux.dev = dev;
20552057
dp->aux.drm_dev = encoder->dev;

0 commit comments

Comments
 (0)