Skip to content

Commit 49988a7

Browse files
jwrdegoedegregkh
authored andcommitted
mei: vsc: Do not re-enable interrupt from vsc_tp_reset()
The only 2 callers of vsc_tp_reset() are: 1. mei_vsc_hw_reset(), which immediataly calls vsc_tp_intr_disable() afterwards. 2. vsc_tp_shutdown() which immediately calls free_irq() afterwards. So neither actually wants the interrupt to be enabled after resetting the chip and having the interrupt enabled for a short time afer the reset is undesirable. Drop the enable_irq() call from vsc_tp_reset(), so that the interrupt is left disabled after vsc_tp_reset(). Link: intel/ivsc-driver#51 Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20241106220102.40549-1-hdegoede@redhat.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 9aa45ca commit 49988a7

2 files changed

Lines changed: 0 additions & 4 deletions

File tree

drivers/misc/mei/platform-vsc.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,8 +256,6 @@ static int mei_vsc_hw_reset(struct mei_device *mei_dev, bool intr_enable)
256256

257257
vsc_tp_reset(hw->tp);
258258

259-
vsc_tp_intr_disable(hw->tp);
260-
261259
return vsc_tp_init(hw->tp, mei_dev->dev);
262260
}
263261

drivers/misc/mei/vsc-tp.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -364,8 +364,6 @@ void vsc_tp_reset(struct vsc_tp *tp)
364364
gpiod_set_value_cansleep(tp->wakeupfw, 1);
365365

366366
atomic_set(&tp->assert_cnt, 0);
367-
368-
enable_irq(tp->spi->irq);
369367
}
370368
EXPORT_SYMBOL_NS_GPL(vsc_tp_reset, VSC_TP);
371369

0 commit comments

Comments
 (0)