Skip to content

Commit 49ee2e8

Browse files
committed
memory: pl353-smc: simplify with dev_err_probe()
Use dev_err_probe() to avoid dmesg flood on actual defer. This makes the code also simpler. Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Link: https://lore.kernel.org/r/20240823-b4-cleanup-h-guard-v1-6-01668915bd55@linaro.org Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
1 parent 610395d commit 49ee2e8

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

drivers/memory/pl353-smc.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -82,16 +82,14 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
8282
return -ENOMEM;
8383

8484
pl353_smc->aclk = devm_clk_get(&adev->dev, "apb_pclk");
85-
if (IS_ERR(pl353_smc->aclk)) {
86-
dev_err(&adev->dev, "aclk clock not found.\n");
87-
return PTR_ERR(pl353_smc->aclk);
88-
}
85+
if (IS_ERR(pl353_smc->aclk))
86+
return dev_err_probe(&adev->dev, PTR_ERR(pl353_smc->aclk),
87+
"aclk clock not found.\n");
8988

9089
pl353_smc->memclk = devm_clk_get(&adev->dev, "memclk");
91-
if (IS_ERR(pl353_smc->memclk)) {
92-
dev_err(&adev->dev, "memclk clock not found.\n");
93-
return PTR_ERR(pl353_smc->memclk);
94-
}
90+
if (IS_ERR(pl353_smc->memclk))
91+
return dev_err_probe(&adev->dev, PTR_ERR(pl353_smc->memclk),
92+
"memclk clock not found.\n");
9593

9694
err = clk_prepare_enable(pl353_smc->aclk);
9795
if (err) {

0 commit comments

Comments
 (0)