mips: ralink: fix a refcount leak in ill_acc_of_setup()

HBh25Y · tsbogend · commit 4a0a1436053b · 2022-03-01T17:25:42.000+01:00
of_node_put(np) needs to be called when pdev == NULL.

Signed-off-by: Hangyu Hua &lt;hbh25y@gmail.com&gt;
Signed-off-by: Thomas Bogendoerfer &lt;tsbogend@alpha.franken.de&gt;
diff --git a/arch/mips/ralink/ill_acc.c b/arch/mips/ralink/ill_acc.c
@@ -61,6 +61,7 @@ static int __init ill_acc_of_setup(void)
 	pdev = of_find_device_by_node(np);
 	if (!pdev) {
 		pr_err("%pOFn: failed to lookup pdev\n", np);
+		of_node_put(np);
 		return -EINVAL;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,7 @@ static int __init ill_acc_of_setup(void)`
`61`	`61`	`pdev = of_find_device_by_node(np);`
`62`	`62`	`if (!pdev) {`
`63`	`63`	`pr_err("%pOFn: failed to lookup pdev\n", np);`
	`64`	`+ of_node_put(np);`
`64`	`65`	`return -EINVAL;`
`65`	`66`	`}`
`66`	`67`