Skip to content

Commit 4a5ef62

Browse files
Uwe Kleine-Könighdeller
authored andcommitted
fbdev: vga16fb: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 24f6770 commit 4a5ef62

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/video/fbdev/vga16fb.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1401,14 +1401,12 @@ static int vga16fb_probe(struct platform_device *dev)
14011401
return ret;
14021402
}
14031403

1404-
static int vga16fb_remove(struct platform_device *dev)
1404+
static void vga16fb_remove(struct platform_device *dev)
14051405
{
14061406
struct fb_info *info = platform_get_drvdata(dev);
14071407

14081408
if (info)
14091409
unregister_framebuffer(info);
1410-
1411-
return 0;
14121410
}
14131411

14141412
static const struct platform_device_id vga16fb_driver_id_table[] = {
@@ -1420,7 +1418,7 @@ MODULE_DEVICE_TABLE(platform, vga16fb_driver_id_table);
14201418

14211419
static struct platform_driver vga16fb_driver = {
14221420
.probe = vga16fb_probe,
1423-
.remove = vga16fb_remove,
1421+
.remove_new = vga16fb_remove,
14241422
.driver = {
14251423
.name = "vga16fb",
14261424
},

0 commit comments

Comments
 (0)