net/smc: return the right falback reason when prefix checks fail

Dust Li · kuba-moo · commit 4abbd2e3c1db · 2023-10-16T16:37:40.000-07:00
In the smc_listen_work(), if smc_listen_prfx_check() failed, the real reason: SMC_CLC_DECL_DIFFPREFIX was dropped, and SMC_CLC_DECL_NOSMCDEV was returned. Althrough this is also kind of SMC_CLC_DECL_NOSMCDEV, but return the real reason is much friendly for debugging. Fixes: e49300a ("net/smc: add listen processing for SMC-Rv2") Signed-off-by: Dust Li <dust.li@linux.alibaba.com> Reviewed-by: Alexandra Winter <wintera@linux.ibm.com> Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com> Link: https://lore.kernel.org/r/20231012123729.29307-1-dust.li@linux.alibaba.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
@@ -2362,7 +2362,7 @@ static int smc_listen_find_device(struct smc_sock *new_smc,
 		smc_find_ism_store_rc(rc, ini);
 		return (!rc) ? 0 : ini->rc;
 	}
-	return SMC_CLC_DECL_NOSMCDEV;
+	return prfx_rc;
 }
 
 /* listen worker: finish RDMA setup */

Original file line number	Diff line number	Diff line change
`@@ -2362,7 +2362,7 @@ static int smc_listen_find_device(struct smc_sock *new_smc,`
`2362`	`2362`	`smc_find_ism_store_rc(rc, ini);`
`2363`	`2363`	`return (!rc) ? 0 : ini->rc;`
`2364`	`2364`	`}`
`2365`		`- return SMC_CLC_DECL_NOSMCDEV;`
	`2365`	`+ return prfx_rc;`
`2366`	`2366`	`}`
`2367`	`2367`
`2368`	`2368`	`/* listen worker: finish RDMA setup */`