Skip to content

Commit 4b9ee77

Browse files
committed
ACPI: scan: Turn off unused power resources during initialization
It is reported that on certain platforms there are power resources that are not associated with any devices physically present in the platform. Those power resources are expected to be turned off by the OS in accordance with the ACPI specification (section 7.3 of ACPI 6.4) which currently is not done by Linux and that may lead to obscure issues. For instance, leaving those power resources in the "on" state may prevent the platform from reaching the lowest power state in suspend-to-idle which leads to excessive power draw. For this reason, turn all of the unused ACPI power resources off at the end of the initial namespace scan for devices in analogy with resume from suspend-to-RAM. Link: https://uefi.org/specs/ACPI/6.4/07_Power_and_Performance_Mgmt/device-power-management-objects.html Reported-by: David Box <david.e.box@linux.intel.com> Tested-by: Wendy Wang <wendy.wang@intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 0d02ec6 commit 4b9ee77

4 files changed

Lines changed: 4 additions & 2 deletions

File tree

drivers/acpi/internal.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,7 @@ int acpi_device_sleep_wake(struct acpi_device *dev,
139139
int acpi_power_get_inferred_state(struct acpi_device *device, int *state);
140140
int acpi_power_on_resources(struct acpi_device *device, int state);
141141
int acpi_power_transition(struct acpi_device *device, int state);
142+
void acpi_turn_off_unused_power_resources(void);
142143

143144
/* --------------------------------------------------------------------------
144145
Device Power Management

drivers/acpi/power.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -996,6 +996,7 @@ void acpi_resume_power_resources(void)
996996

997997
mutex_unlock(&power_resource_list_lock);
998998
}
999+
#endif
9991000

10001001
void acpi_turn_off_unused_power_resources(void)
10011002
{
@@ -1025,4 +1026,3 @@ void acpi_turn_off_unused_power_resources(void)
10251026

10261027
mutex_unlock(&power_resource_list_lock);
10271028
}
1028-
#endif

drivers/acpi/scan.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2360,6 +2360,8 @@ int __init acpi_scan_init(void)
23602360
}
23612361
}
23622362

2363+
acpi_turn_off_unused_power_resources();
2364+
23632365
acpi_scan_initialized = true;
23642366

23652367
out:

drivers/acpi/sleep.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ extern struct list_head acpi_wakeup_device_list;
88
extern struct mutex acpi_device_lock;
99

1010
extern void acpi_resume_power_resources(void);
11-
extern void acpi_turn_off_unused_power_resources(void);
1211

1312
static inline acpi_status acpi_set_waking_vector(u32 wakeup_address)
1413
{

0 commit comments

Comments
 (0)