Skip to content

Commit 4bd8405

Browse files
Joshua Yeongalexandrebelloni
authored andcommitted
i3c: master: cdns: Fix reading status register
IBIR_DEPTH and CMDR_DEPTH should read from status0 instead of status1. Cc: stable@vger.kernel.org Fixes: 603f2be ("i3c: master: Add driver for Cadence IP") Signed-off-by: Joshua Yeong <joshua.yeong@starfivetech.com> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/r/20230913031743.11439-2-joshua.yeong@starfivetech.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent 0bb80ec commit 4bd8405

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/i3c/master/i3c-master-cdns.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@
191191
#define SLV_STATUS1_HJ_DIS BIT(18)
192192
#define SLV_STATUS1_MR_DIS BIT(17)
193193
#define SLV_STATUS1_PROT_ERR BIT(16)
194-
#define SLV_STATUS1_DA(x) (((s) & GENMASK(15, 9)) >> 9)
194+
#define SLV_STATUS1_DA(s) (((s) & GENMASK(15, 9)) >> 9)
195195
#define SLV_STATUS1_HAS_DA BIT(8)
196196
#define SLV_STATUS1_DDR_RX_FULL BIT(7)
197197
#define SLV_STATUS1_DDR_TX_FULL BIT(6)
@@ -1623,13 +1623,13 @@ static int cdns_i3c_master_probe(struct platform_device *pdev)
16231623
/* Device ID0 is reserved to describe this master. */
16241624
master->maxdevs = CONF_STATUS0_DEVS_NUM(val);
16251625
master->free_rr_slots = GENMASK(master->maxdevs, 1);
1626+
master->caps.ibirfifodepth = CONF_STATUS0_IBIR_DEPTH(val);
1627+
master->caps.cmdrfifodepth = CONF_STATUS0_CMDR_DEPTH(val);
16261628

16271629
val = readl(master->regs + CONF_STATUS1);
16281630
master->caps.cmdfifodepth = CONF_STATUS1_CMD_DEPTH(val);
16291631
master->caps.rxfifodepth = CONF_STATUS1_RX_DEPTH(val);
16301632
master->caps.txfifodepth = CONF_STATUS1_TX_DEPTH(val);
1631-
master->caps.ibirfifodepth = CONF_STATUS0_IBIR_DEPTH(val);
1632-
master->caps.cmdrfifodepth = CONF_STATUS0_CMDR_DEPTH(val);
16331633

16341634
spin_lock_init(&master->ibi.lock);
16351635
master->ibi.num_slots = CONF_STATUS1_IBI_HW_RES(val);

0 commit comments

Comments
 (0)