Skip to content

Commit 4c350c6

Browse files
Linus Walleijpavelmachek
authored andcommitted
leds: regulator: Add dev helper variable
Instead of repeating the hard to read &pdev->dev just create a local struct device *dev in probe(). Cc: Antonio Ospite <ao2@ao2.it> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Pavel Machek <pavel@ucw.cz>
1 parent 5a71917 commit 4c350c6

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

drivers/leds/leds-regulator.c

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -123,28 +123,29 @@ static int regulator_led_probe(struct platform_device *pdev)
123123
{
124124
struct led_regulator_platform_data *pdata =
125125
dev_get_platdata(&pdev->dev);
126+
struct device *dev = &pdev->dev;
126127
struct regulator_led *led;
127128
struct regulator *vcc;
128129
int ret = 0;
129130

130131
if (pdata == NULL) {
131-
dev_err(&pdev->dev, "no platform data\n");
132+
dev_err(dev, "no platform data\n");
132133
return -ENODEV;
133134
}
134135

135-
vcc = devm_regulator_get_exclusive(&pdev->dev, "vled");
136+
vcc = devm_regulator_get_exclusive(dev, "vled");
136137
if (IS_ERR(vcc)) {
137-
dev_err(&pdev->dev, "Cannot get vcc for %s\n", pdata->name);
138+
dev_err(dev, "Cannot get vcc for %s\n", pdata->name);
138139
return PTR_ERR(vcc);
139140
}
140141

141-
led = devm_kzalloc(&pdev->dev, sizeof(*led), GFP_KERNEL);
142+
led = devm_kzalloc(dev, sizeof(*led), GFP_KERNEL);
142143
if (led == NULL)
143144
return -ENOMEM;
144145

145146
led->cdev.max_brightness = led_regulator_get_max_brightness(vcc);
146147
if (pdata->brightness > led->cdev.max_brightness) {
147-
dev_err(&pdev->dev, "Invalid default brightness %d\n",
148+
dev_err(dev, "Invalid default brightness %d\n",
148149
pdata->brightness);
149150
return -EINVAL;
150151
}
@@ -162,7 +163,7 @@ static int regulator_led_probe(struct platform_device *pdev)
162163

163164
platform_set_drvdata(pdev, led);
164165

165-
ret = led_classdev_register(&pdev->dev, &led->cdev);
166+
ret = led_classdev_register(dev, &led->cdev);
166167
if (ret < 0)
167168
return ret;
168169

0 commit comments

Comments
 (0)