Skip to content

Commit 4c60d04

Browse files
kuba-moodavem330
authored andcommitted
net: skbuff: push nf_trace down the bitfield
nf_trace is a debug feature, AFAIU, and yet it sits oddly high in the sk_buff bitfield. Move it down, pushing up dst_pending_confirm and inner_protocol_type. Next change will make nf_trace optional (under Kconfig) and all optional fields should be placed after 2b fields to avoid 2b fields straddling bytes. dst_pending_confirm is L3, so it makes sense next to ignore_df. inner_protocol_type goes up just to keep the balance. Acked-by: Florian Westphal <fw@strlen.de> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Reviewed-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 4398f3f commit 4c60d04

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

include/linux/skbuff.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -934,7 +934,7 @@ struct sk_buff {
934934
/* public: */
935935
__u8 pkt_type:3; /* see PKT_TYPE_MAX */
936936
__u8 ignore_df:1;
937-
__u8 nf_trace:1;
937+
__u8 dst_pending_confirm:1;
938938
__u8 ip_summed:2;
939939
__u8 ooo_okay:1;
940940

@@ -949,7 +949,7 @@ struct sk_buff {
949949
__u8 remcsum_offload:1;
950950
__u8 csum_complete_sw:1;
951951
__u8 csum_level:2;
952-
__u8 dst_pending_confirm:1;
952+
__u8 inner_protocol_type:1;
953953

954954
__u8 l4_hash:1;
955955
__u8 sw_hash:1;
@@ -967,7 +967,7 @@ struct sk_buff {
967967
#endif
968968

969969
__u8 ipvs_property:1;
970-
__u8 inner_protocol_type:1;
970+
__u8 nf_trace:1;
971971
#ifdef CONFIG_NET_SWITCHDEV
972972
__u8 offload_fwd_mark:1;
973973
__u8 offload_l3_fwd_mark:1;

0 commit comments

Comments
 (0)