Skip to content

Commit 4c60d49

Browse files
rddunlapJonathan Corbet
authored andcommitted
Documentation: KVM: make corrections to halt-polling.rst
Module parameters are in sysfs, not debugfs, so change that. Remove superfluous "that" following "Note:". Hyphenate "system-wide" values. Hyphenate "trade-off". Don't treat "denial of service" as a verb. Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: Suraj Jitindar Singh <sjitindarsingh@gmail.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Sean Christopherson <seanjc@google.com> Cc: kvm@vger.kernel.org Cc: Jonathan Corbet <corbet@lwn.net> Cc: linux-doc@vger.kernel.org Signed-off-by: Jonathan Corbet <corbet@lwn.net> Link: https://lore.kernel.org/r/20230612030810.23376-2-rdunlap@infradead.org
1 parent 1954d51 commit 4c60d49

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

Documentation/virt/kvm/halt-polling.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,11 @@ powerpc kvm-hv case.
112112
| | function. | |
113113
+-----------------------+---------------------------+-------------------------+
114114

115-
These module parameters can be set from the debugfs files in:
115+
These module parameters can be set from the sysfs files in:
116116

117117
/sys/module/kvm/parameters/
118118

119-
Note: that these module parameters are system wide values and are not able to
119+
Note: these module parameters are system-wide values and are not able to
120120
be tuned on a per vm basis.
121121

122122
Any changes to these parameters will be picked up by new and existing vCPUs the
@@ -142,12 +142,12 @@ Further Notes
142142
global max polling interval (halt_poll_ns) then the host will always poll for the
143143
entire block time and thus cpu utilisation will go to 100%.
144144

145-
- Halt polling essentially presents a trade off between power usage and latency and
145+
- Halt polling essentially presents a trade-off between power usage and latency and
146146
the module parameters should be used to tune the affinity for this. Idle cpu time is
147147
essentially converted to host kernel time with the aim of decreasing latency when
148148
entering the guest.
149149

150150
- Halt polling will only be conducted by the host when no other tasks are runnable on
151151
that cpu, otherwise the polling will cease immediately and schedule will be invoked to
152-
allow that other task to run. Thus this doesn't allow a guest to denial of service the
153-
cpu.
152+
allow that other task to run. Thus this doesn't allow a guest to cause denial of service
153+
of the cpu.

0 commit comments

Comments
 (0)