ieee802154: cc2520: Fix error return code in cc2520_hw_init()

Ziyang Xuan · Stefan-Schmidt · commit 4d002d6a2a00 · 2022-11-29T14:51:28.000+01:00
In cc2520_hw_init(), if oscillator start failed, the error code should be returned. Fixes: 0da6bc8 ("ieee802154: cc2520: adds driver for TI CC2520 radio") Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com> Link: https://lore.kernel.org/r/20221120075046.2213633-1-william.xuanziyang@huawei.com Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
@@ -970,7 +970,7 @@ static int cc2520_hw_init(struct cc2520_private *priv)
 
 		if (timeout-- <= 0) {
 			dev_err(&priv->spi->dev, "oscillator start failed!\n");
-			return ret;
+			return -ETIMEDOUT;
 		}
 		udelay(1);
 	} while (!(status & CC2520_STATUS_XOSC32M_STABLE));

Original file line number	Diff line number	Diff line change
`@@ -970,7 +970,7 @@ static int cc2520_hw_init(struct cc2520_private *priv)`
`970`	`970`
`971`	`971`	`if (timeout-- <= 0) {`
`972`	`972`	`dev_err(&priv->spi->dev, "oscillator start failed!\n");`
`973`		`- return ret;`
	`973`	`+ return -ETIMEDOUT;`
`974`	`974`	`}`
`975`	`975`	`udelay(1);`
`976`	`976`	`} while (!(status & CC2520_STATUS_XOSC32M_STABLE));`