Skip to content

Commit 4d9890a

Browse files
robherringalexandrebelloni
authored andcommitted
rtc: sun6i: Use of_property_present() for testing DT property presence
It is preferred to use typed property access functions (i.e. of_property_read_<type> functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more. Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Link: https://lore.kernel.org/r/20230310144736.1547041-1-robh@kernel.org Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent f12f0c7 commit 4d9890a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/rtc/rtc-sun6i.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ static void __init sun6i_rtc_clk_init(struct device_node *node,
260260
}
261261

262262
/* Switch to the external, more precise, oscillator, if present */
263-
if (of_get_property(node, "clocks", NULL)) {
263+
if (of_property_present(node, "clocks")) {
264264
reg |= SUN6I_LOSC_CTRL_EXT_OSC;
265265
if (rtc->data->has_losc_en)
266266
reg |= SUN6I_LOSC_CTRL_EXT_LOSC_EN;

0 commit comments

Comments
 (0)