Skip to content

Commit 4deef81

Browse files
robclarkChun-Kuang Hu
authored andcommitted
drm/mediatek: Drop unbalanced obj unref
In the error path, mtk_drm_gem_object_mmap() is dropping an obj reference that it doesn't own. Fixes: 119f517 ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Rob Clark <robdclark@chromium.org> Link: https://patchwork.kernel.org/project/linux-mediatek/patch/20230119231255.2883365-1-robdclark@gmail.com/ Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
1 parent 2ea8aec commit 4deef81

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/gpu/drm/mediatek/mtk_drm_gem.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,6 @@ static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj,
169169

170170
ret = dma_mmap_attrs(priv->dma_dev, vma, mtk_gem->cookie,
171171
mtk_gem->dma_addr, obj->size, mtk_gem->dma_attrs);
172-
if (ret)
173-
drm_gem_vm_close(vma);
174172

175173
return ret;
176174
}

0 commit comments

Comments
 (0)