rtc: pcf2127: fix error code in pcf2127_enable_ts()

Dan Carpenter · alexandrebelloni · commit 4e5eb7ef73c4 · 2023-08-17T00:58:35.000+02:00
This error path accidentally returns success. Return -EINVAL instead. Fixes: 420cc9e ("rtc: pcf2127: add support for multiple TS functions") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Bruno Thomsen <bruno.thomsen@gmail.com> Reviewed-by: Hugo Villeneuve <hugo@hugovil.com> Reviewed-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> Link: https://lore.kernel.org/r/55b9c84b-9d21-444f-b91a-cf9316b65833@moroto.mountain Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c
@@ -1060,7 +1060,7 @@ static int pcf2127_enable_ts(struct device *dev, int ts_id)
 	if (pcf2127->cfg->ts[ts_id].gnd_detect_bit == 0) {
 		dev_err(dev, "%s: tamper detection to GND configuration invalid\n",
 			__func__);
-		return ret;
+		return -EINVAL;
 	}
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -1060,7 +1060,7 @@ static int pcf2127_enable_ts(struct device *dev, int ts_id)`
`1060`	`1060`	`if (pcf2127->cfg->ts[ts_id].gnd_detect_bit == 0) {`
`1061`	`1061`	`dev_err(dev, "%s: tamper detection to GND configuration invalid\n",`
`1062`	`1062`	`__func__);`
`1063`		`- return ret;`
	`1063`	`+ return -EINVAL;`
`1064`	`1064`	`}`
`1065`	`1065`
`1066`	`1066`	`/*`