wifi: iwlwifi: mvm: fix primary link setting

Miriam-Rachel · jmberg-intel · commit 4e8a56aab3fb · 2024-05-06T16:33:25.000+02:00
mvmvif::primary link holds the ID and not a bitmap. Fix this Fixes: 07bf529 ("wifi: iwlwifi: mvm: Implement new link selection algorithm") Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com> Reviewed-by: Johannes Berg <johannes.berg@intel.com> Link: https://msgid.link/20240506095953.779bf6949053.Ia9297991ff2fdc82ae7c730e0069e2dd6e5f2902@changeid Signed-off-by: Johannes Berg <johannes.berg@intel.com>
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-mac80211.c
@@ -1212,7 +1212,7 @@ iwl_mvm_mld_change_vif_links(struct ieee80211_hw *hw,
 		 * Ensure we always have a valid primary_link, the real
 		 * decision happens later when PHY is activated.
 		 */
-		mvmvif->primary_link = BIT(__ffs(new_links));
+		mvmvif->primary_link = __ffs(new_links);
 	}
 
 out_err:

Original file line number	Diff line number	Diff line change
`@@ -1212,7 +1212,7 @@ iwl_mvm_mld_change_vif_links(struct ieee80211_hw *hw,`
`1212`	`1212`	`* Ensure we always have a valid primary_link, the real`
`1213`	`1213`	`* decision happens later when PHY is activated.`
`1214`	`1214`	`*/`
`1215`		`- mvmvif->primary_link = BIT(__ffs(new_links));`
	`1215`	`+ mvmvif->primary_link = __ffs(new_links);`
`1216`	`1216`	`}`
`1217`	`1217`
`1218`	`1218`	`out_err:`