Skip to content

Commit 4ea7ce0

Browse files
mrutland-armKAGA-KOKO
authored andcommitted
openrisc: Snapshot thread flags
Some thread flags can be set remotely, and so even when IRQs are disabled, the flags can change under our feet. Generally this is unlikely to cause a problem in practice, but it is somewhat unsound, and KCSAN will legitimately warn that there is a data race. To avoid such issues, a snapshot of the flags has to be taken prior to using them. Some places already use READ_ONCE() for that, others do not. Convert them all to the new flag accessor helpers. Signed-off-by: Mark Rutland <mark.rutland@arm.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Stafford Horne <shorne@gmail.com> Acked-by: Paul E. McKenney <paulmck@kernel.org> Cc: Jonas Bonn <jonas@southpole.se> Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi> Link: https://lore.kernel.org/r/20211129130653.2037928-9-mark.rutland@arm.com
1 parent e538c58 commit 4ea7ce0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/openrisc/kernel/signal.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ do_work_pending(struct pt_regs *regs, unsigned int thread_flags, int syscall)
313313
}
314314
}
315315
local_irq_disable();
316-
thread_flags = current_thread_info()->flags;
316+
thread_flags = read_thread_flags();
317317
} while (thread_flags & _TIF_WORK_MASK);
318318
return 0;
319319
}

0 commit comments

Comments
 (0)