Skip to content

Commit 4edc076

Browse files
dhowellstorvalds
authored andcommitted
watch_queue: Make comment about setting ->defunct more accurate
watch_queue_clear() has a comment stating that setting ->defunct to true preventing new additions as well as preventing notifications. Whilst the latter is true, the first bit is superfluous since at the time this function is called, the pipe cannot be accessed to add new event sources. Remove the "new additions" bit from the comment. Fixes: c73be61 ("pipe: Add general notification queue support") Reported-by: Jann Horn <jannh@google.com> Signed-off-by: David Howells <dhowells@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 2ed147f commit 4edc076

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

kernel/watch_queue.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,7 @@ void watch_queue_clear(struct watch_queue *wqueue)
566566
rcu_read_lock();
567567
spin_lock_bh(&wqueue->lock);
568568

569-
/* Prevent new additions and prevent notifications from happening */
569+
/* Prevent new notifications from being stored. */
570570
wqueue->defunct = true;
571571

572572
while (!hlist_empty(&wqueue->watches)) {

0 commit comments

Comments
 (0)