Skip to content

Commit 4f23f6d

Browse files
YongWu-HFjoergroedel
authored andcommitted
iommu/mediatek: Always tlb_flush_all when each PM resume
Prepare for 2 HWs that sharing pgtable in different power-domains. When there are 2 M4U HWs, it may has problem in the flush_range in which we get the pm_status via the m4u dev, BUT that function don't reflect the real power-domain status of the HW since there may be other HW also use that power-domain. DAM allocation is often done while the allocating device is runtime suspended. In such a case the iommu will also be suspended and partial flushing of the tlb will not be executed. Therefore, we add a tlb_flush_all in the pm_runtime_resume to make sure the tlb is always clean. In other case, the iommu's power should be active via device link with smi. Signed-off-by: Yong Wu <yong.wu@mediatek.com> [move the call to mtk_iommu_tlb_flush_all to the bottom of resume cb, improve doc/log] Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://lore.kernel.org/r/20211208120744.2415-6-dafna.hirschfeld@collabora.com Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent 15672b6 commit 4f23f6d

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

drivers/iommu/mtk_iommu.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -975,6 +975,13 @@ static int __maybe_unused mtk_iommu_runtime_resume(struct device *dev)
975975
writel_relaxed(reg->ivrp_paddr, base + REG_MMU_IVRP_PADDR);
976976
writel_relaxed(reg->vld_pa_rng, base + REG_MMU_VLD_PA_RNG);
977977
writel(m4u_dom->cfg.arm_v7s_cfg.ttbr & MMU_PT_ADDR_MASK, base + REG_MMU_PT_BASE_ADDR);
978+
979+
/*
980+
* Users may allocate dma buffer before they call pm_runtime_get,
981+
* in which case it will lack the necessary tlb flush.
982+
* Thus, make sure to update the tlb after each PM resume.
983+
*/
984+
mtk_iommu_tlb_flush_all(data);
978985
return 0;
979986
}
980987

0 commit comments

Comments
 (0)