Skip to content

Commit 502892b

Browse files
irui-wangHans Verkuil
authored andcommitted
media: mediatek: vcodec: Handle VP9 superframe bitstream with 8 sub-frames
The VP9 bitstream uses superframes, which each contain 8 sub-frames, enable accessing the last superframe by increasing the range of the index vaidation as the maximum number of superframes is 8 and not 7, so that the last sub-frame can be decoded normally with the stateful VP9 decoder. Signed-off-by: Irui Wang <irui.wang@mediatek.com> Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
1 parent 4cece76 commit 502892b

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_if.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
#include "../vdec_drv_base.h"
1717
#include "../vdec_vpu_if.h"
1818

19+
#define VP9_MAX_SUPER_FRAMES_NUM 8
1920
#define VP9_SUPER_FRAME_BS_SZ 64
2021
#define MAX_VP9_DPB_SIZE 9
2122

@@ -133,11 +134,11 @@ struct vp9_sf_ref_fb {
133134
*/
134135
struct vdec_vp9_vsi {
135136
unsigned char sf_bs_buf[VP9_SUPER_FRAME_BS_SZ];
136-
struct vp9_sf_ref_fb sf_ref_fb[VP9_MAX_FRM_BUF_NUM-1];
137+
struct vp9_sf_ref_fb sf_ref_fb[VP9_MAX_SUPER_FRAMES_NUM];
137138
int sf_next_ref_fb_idx;
138139
unsigned int sf_frm_cnt;
139-
unsigned int sf_frm_offset[VP9_MAX_FRM_BUF_NUM-1];
140-
unsigned int sf_frm_sz[VP9_MAX_FRM_BUF_NUM-1];
140+
unsigned int sf_frm_offset[VP9_MAX_SUPER_FRAMES_NUM];
141+
unsigned int sf_frm_sz[VP9_MAX_SUPER_FRAMES_NUM];
141142
unsigned int sf_frm_idx;
142143
unsigned int sf_init;
143144
struct vdec_fb fb;
@@ -526,7 +527,7 @@ static void vp9_swap_frm_bufs(struct vdec_vp9_inst *inst)
526527
/* if this super frame and it is not last sub-frame, get next fb for
527528
* sub-frame decode
528529
*/
529-
if (vsi->sf_frm_cnt > 0 && vsi->sf_frm_idx != vsi->sf_frm_cnt - 1)
530+
if (vsi->sf_frm_cnt > 0 && vsi->sf_frm_idx != vsi->sf_frm_cnt)
530531
vsi->sf_next_ref_fb_idx = vp9_get_sf_ref_fb(inst);
531532
}
532533

@@ -735,7 +736,7 @@ static void get_free_fb(struct vdec_vp9_inst *inst, struct vdec_fb **out_fb)
735736

736737
static int validate_vsi_array_indexes(struct vdec_vp9_inst *inst,
737738
struct vdec_vp9_vsi *vsi) {
738-
if (vsi->sf_frm_idx >= VP9_MAX_FRM_BUF_NUM - 1) {
739+
if (vsi->sf_frm_idx > VP9_MAX_SUPER_FRAMES_NUM) {
739740
mtk_vdec_err(inst->ctx, "Invalid vsi->sf_frm_idx=%u.", vsi->sf_frm_idx);
740741
return -EIO;
741742
}

0 commit comments

Comments
 (0)