drm/amdgpu: fix double free err_addr pointer warnings

Bob Zhou · alexdeucher · commit 506c245f3f1c · 2024-04-26T17:22:43.000-04:00
In amdgpu_umc_bad_page_polling_timeout, the amdgpu_umc_handle_bad_pages
will be run many times so that double free err_addr in some special case.
So set the err_addr to NULL to avoid the warnings.

Signed-off-by: Bob Zhou &lt;bob.zhou@amd.com&gt;
Acked-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
Signed-off-by: Alex Deucher &lt;alexander.deucher@amd.com&gt;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c
@@ -179,6 +179,7 @@ void amdgpu_umc_handle_bad_pages(struct amdgpu_device *adev,
 	}
 
 	kfree(err_data->err_addr);
+	err_data->err_addr = NULL;
 
 	mutex_unlock(&con->page_retirement_lock);
 }

Original file line number	Diff line number	Diff line change
`@@ -179,6 +179,7 @@ void amdgpu_umc_handle_bad_pages(struct amdgpu_device *adev,`
`179`	`179`	`}`
`180`	`180`
`181`	`181`	`kfree(err_data->err_addr);`
	`182`	`+ err_data->err_addr = NULL;`
`182`	`183`
`183`	`184`	`mutex_unlock(&con->page_retirement_lock);`
`184`	`185`	`}`