Skip to content

Commit 50db438

Browse files
committed
cpuidle: governors: teo: Fix tick_intercepts handling in teo_update()
The condition deciding whether or not to increase cpu_data->tick_intercepts in teo_update() is reverse, so fix it. Fixes: d619b5c ("cpuidle: teo: Simplify counting events used for tick management") Cc: 6.14+ <stable@vger.kernel.org> # 6.14+: 0796ddf: cpuidle: teo: Use this_cpu_ptr() where possible Cc: 6.14+ <stable@vger.kernel.org> # 6.14+: 8f3f010: cpuidle: governors: teo: Use s64 consistently in teo_update() Cc: 6.14+ <stable@vger.kernel.org> # 6.14+: b54df61: cpuidle: governors: teo: Decay metrics below DECAY_SHIFT threshold Cc: 6.14+ <stable@vger.kernel.org> 6.14+: 083654d: cpuidle: governors: teo: Rework the handling of tick wakeups Cc: 6.14+ <stable@vger.kernel.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Reviewed-by: Christian Loehle <christian.loehle@arm.com> Link: https://patch.msgid.link/5085160.31r3eYUQgx@rafael.j.wysocki
1 parent 083654d commit 50db438

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • drivers/cpuidle/governors

drivers/cpuidle/governors/teo.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev)
251251
cpu_data->state_bins[idx_timer].hits += PULSE;
252252
} else {
253253
cpu_data->state_bins[idx_duration].intercepts += PULSE;
254-
if (TICK_NSEC <= measured_ns)
254+
if (measured_ns <= TICK_NSEC)
255255
cpu_data->tick_intercepts += PULSE;
256256
}
257257
}

0 commit comments

Comments
 (0)