ovl: handle idmappings for layer fileattrs

brauner · Miklos Szeredi · commit 50db8d027355 · 2022-04-28T16:31:11.000+02:00
Take the upper mount's idmapping into account when setting fileattrs on
the upper layer. This is needed to support idmapped base layers with
overlay.

Cc: &lt;linux-unionfs@vger.kernel.org&gt;
Tested-by: Giuseppe Scrivano &lt;gscrivan@redhat.com&gt;
Reviewed-by: Amir Goldstein &lt;amir73il@gmail.com&gt;
Signed-off-by: Christian Brauner (Microsoft) &lt;brauner@kernel.org&gt;
Signed-off-by: Miklos Szeredi &lt;mszeredi@redhat.com&gt;
diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
@@ -537,7 +537,7 @@ int ovl_real_fileattr_set(struct path *realpath, struct fileattr *fa)
 	if (err)
 		return err;
 
-	return vfs_fileattr_set(&init_user_ns, realpath->dentry, fa);
+	return vfs_fileattr_set(mnt_user_ns(realpath->mnt), realpath->dentry, fa);
 }
 
 int ovl_fileattr_set(struct user_namespace *mnt_userns,

Original file line number	Diff line number	Diff line change
`@@ -537,7 +537,7 @@ int ovl_real_fileattr_set(struct path realpath, struct fileattr fa)`
`537`	`537`	`if (err)`
`538`	`538`	`return err;`
`539`	`539`
`540`		`- return vfs_fileattr_set(&init_user_ns, realpath->dentry, fa);`
	`540`	`+ return vfs_fileattr_set(mnt_user_ns(realpath->mnt), realpath->dentry, fa);`
`541`	`541`	`}`
`542`	`542`
`543`	`543`	`int ovl_fileattr_set(struct user_namespace *mnt_userns,`