SUNRPC: Fix missing release socket in rpc_sockname()

Wang ShaoBo · Trond Myklebust · commit 50fa355bc0d7 · 2022-12-06T12:21:38.000-05:00
socket dynamically created is not released when getting an unintended address family type in rpc_sockname(), direct to out_release for calling sock_release(). Fixes: 2e738fd ("SUNRPC: Add API to acquire source address") Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
@@ -1442,7 +1442,7 @@ static int rpc_sockname(struct net *net, struct sockaddr *sap, size_t salen,
 		break;
 	default:
 		err = -EAFNOSUPPORT;
-		goto out;
+		goto out_release;
 	}
 	if (err < 0) {
 		dprintk("RPC:       can't bind UDP socket (%d)\n", err);

Original file line number	Diff line number	Diff line change
`@@ -1442,7 +1442,7 @@ static int rpc_sockname(struct net net, struct sockaddr sap, size_t salen,`
`1442`	`1442`	`break;`
`1443`	`1443`	`default:`
`1444`	`1444`	`err = -EAFNOSUPPORT;`
`1445`		`- goto out;`
	`1445`	`+ goto out_release;`
`1446`	`1446`	`}`
`1447`	`1447`	`if (err < 0) {`
`1448`	`1448`	`dprintk("RPC: can't bind UDP socket (%d)\n", err);`