Skip to content

Commit 5122758

Browse files
author
Bartosz Golaszewski
committed
gpio: mc33880: use new GPIO line value setter callbacks
struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Link: https://lore.kernel.org/r/20250506-gpiochip-set-rv-gpio-part3-v1-11-0fbdea5a9667@linaro.org Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
1 parent dff5a31 commit 5122758

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

drivers/gpio/gpio-mc33880.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,18 @@ static int __mc33880_set(struct mc33880 *mc, unsigned offset, int value)
5757
}
5858

5959

60-
static void mc33880_set(struct gpio_chip *chip, unsigned offset, int value)
60+
static int mc33880_set(struct gpio_chip *chip, unsigned int offset, int value)
6161
{
6262
struct mc33880 *mc = gpiochip_get_data(chip);
63+
int ret;
6364

6465
mutex_lock(&mc->lock);
6566

66-
__mc33880_set(mc, offset, value);
67+
ret = __mc33880_set(mc, offset, value);
6768

6869
mutex_unlock(&mc->lock);
70+
71+
return ret;
6972
}
7073

7174
static int mc33880_probe(struct spi_device *spi)
@@ -100,7 +103,7 @@ static int mc33880_probe(struct spi_device *spi)
100103
mc->spi = spi;
101104

102105
mc->chip.label = DRIVER_NAME;
103-
mc->chip.set = mc33880_set;
106+
mc->chip.set_rv = mc33880_set;
104107
mc->chip.base = pdata->base;
105108
mc->chip.ngpio = PIN_NUMBER;
106109
mc->chip.can_sleep = true;

0 commit comments

Comments
 (0)