Skip to content

Commit 519b227

Browse files
michichkuba-moo
authored andcommitted
octeon_ep: fix timeout value for waiting on mbox response
The intention was to wait up to 500 ms for the mbox response. The third argument to wait_event_interruptible_timeout() is supposed to be the timeout duration. The driver mistakenly passed absolute time instead. Fixes: 577f0d1 ("octeon_ep: add separate mailbox command and response queues") Signed-off-by: Michal Schmidt <mschmidt@redhat.com> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://lore.kernel.org/r/20230810150114.107765-2-mschmidt@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 6c461e3 commit 519b227

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/net/ethernet/marvell/octeon_ep/octep_ctrl_net.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ static int octep_send_mbox_req(struct octep_device *oct,
5555
list_add_tail(&d->list, &oct->ctrl_req_wait_list);
5656
ret = wait_event_interruptible_timeout(oct->ctrl_req_wait_q,
5757
(d->done != 0),
58-
jiffies + msecs_to_jiffies(500));
58+
msecs_to_jiffies(500));
5959
list_del(&d->list);
6060
if (ret == 0 || ret == 1)
6161
return -EAGAIN;

0 commit comments

Comments
 (0)