Skip to content

Commit 519e5cc

Browse files
Uwe Kleine-Königlag-linaro
authored andcommitted
backlight: mt6370-backlight: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by: Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/20230308073945.2336302-10-u.kleine-koenig@pengutronix.de
1 parent 1c708d3 commit 519e5cc

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/video/backlight/mt6370-backlight.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -318,15 +318,13 @@ static int mt6370_bl_probe(struct platform_device *pdev)
318318
return 0;
319319
}
320320

321-
static int mt6370_bl_remove(struct platform_device *pdev)
321+
static void mt6370_bl_remove(struct platform_device *pdev)
322322
{
323323
struct mt6370_priv *priv = platform_get_drvdata(pdev);
324324
struct backlight_device *bl_dev = priv->bl;
325325

326326
bl_dev->props.brightness = 0;
327327
backlight_update_status(priv->bl);
328-
329-
return 0;
330328
}
331329

332330
static const struct of_device_id mt6370_bl_of_match[] = {
@@ -342,7 +340,7 @@ static struct platform_driver mt6370_bl_driver = {
342340
.of_match_table = mt6370_bl_of_match,
343341
},
344342
.probe = mt6370_bl_probe,
345-
.remove = mt6370_bl_remove,
343+
.remove_new = mt6370_bl_remove,
346344
};
347345
module_platform_driver(mt6370_bl_driver);
348346

0 commit comments

Comments
 (0)