media: qcom: venus: fix incorrect return value

Hans Verkuil · Hans Verkuil · commit 51b74c09ac8c · 2023-10-12T10:12:54.000+02:00
'pd' can be NULL, and in that case it shouldn't be passed to
PTR_ERR. Fixes a smatch warning:

drivers/media/platform/qcom/venus/pm_helpers.c:873 vcodec_domains_get() warn: passing zero to 'PTR_ERR'

Signed-off-by: Hans Verkuil &lt;hverkuil-cisco@xs4all.nl&gt;
Reviewed-by: Bryan O'Donoghue &lt;bryan.odonoghue@linaro.org&gt;
diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c
@@ -870,7 +870,7 @@ static int vcodec_domains_get(struct venus_core *core)
 		pd = dev_pm_domain_attach_by_name(dev,
 						  res->vcodec_pmdomains[i]);
 		if (IS_ERR_OR_NULL(pd))
-			return PTR_ERR(pd) ? : -ENODATA;
+			return pd ? PTR_ERR(pd) : -ENODATA;
 		core->pmdomains[i] = pd;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -870,7 +870,7 @@ static int vcodec_domains_get(struct venus_core *core)`
`870`	`870`	`pd = dev_pm_domain_attach_by_name(dev,`
`871`	`871`	`res->vcodec_pmdomains[i]);`
`872`	`872`	`if (IS_ERR_OR_NULL(pd))`
`873`		`- return PTR_ERR(pd) ? : -ENODATA;`
	`873`	`+ return pd ? PTR_ERR(pd) : -ENODATA;`
`874`	`874`	`core->pmdomains[i] = pd;`
`875`	`875`	`}`
`876`	`876`