Skip to content

Commit 51f96e2

Browse files
paliLorenzo Pieralisi
authored andcommitted
PCI: aardvark: Check return value of generic_handle_domain_irq() when processing INTx IRQ
It is possible that we receive spurious INTx interrupt. Check for the return value of generic_handle_domain_irq() when processing INTx IRQ. Link: https://lore.kernel.org/r/20220110015018.26359-6-kabel@kernel.org Signed-off-by: Pali Rohár <pali@kernel.org> Signed-off-by: Marek Behún <kabel@kernel.org> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
1 parent 1571d67 commit 51f96e2

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/pci/controller/pci-aardvark.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1425,7 +1425,9 @@ static void advk_pcie_handle_int(struct advk_pcie *pcie)
14251425
advk_writel(pcie, PCIE_ISR1_INTX_ASSERT(i),
14261426
PCIE_ISR1_REG);
14271427

1428-
generic_handle_domain_irq(pcie->irq_domain, i);
1428+
if (generic_handle_domain_irq(pcie->irq_domain, i) == -EINVAL)
1429+
dev_err_ratelimited(&pcie->pdev->dev, "unexpected INT%c IRQ\n",
1430+
(char)i + 'A');
14291431
}
14301432
}
14311433

0 commit comments

Comments
 (0)