Skip to content

Commit 5214ff2

Browse files
Richard Zhukwilczynski
authored andcommitted
PCI: imx6: Fix establish link failure in EP mode for i.MX8MM and i.MX8MP
Add IMX6_PCIE_FLAG_HAS_APP_RESET flag to IMX8MM_EP and IMX8MP_EP drvdata. This flag was overlooked during code restructuring. It is crucial to release the app-reset from the System Reset Controller before initiating LTSSM to rectify the issue. Fixes: 0c9651c ("PCI: imx6: Simplify reset handling by using *_FLAG_HAS_*_RESET") Link: https://lore.kernel.org/linux-pci/20240729-pci2_upstream-v8-1-b68ee5ef2b4d@nxp.com Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> Signed-off-by: Frank Li <Frank.Li@nxp.com> [kwilczynski: commit log] Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Cc: <stable@vger.kernel.org> # 6.9+
1 parent 8400291 commit 5214ff2

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

drivers/pci/controller/dwc/pci-imx6.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1562,7 +1562,8 @@ static const struct imx6_pcie_drvdata drvdata[] = {
15621562
},
15631563
[IMX8MM_EP] = {
15641564
.variant = IMX8MM_EP,
1565-
.flags = IMX6_PCIE_FLAG_HAS_PHYDRV,
1565+
.flags = IMX6_PCIE_FLAG_HAS_APP_RESET |
1566+
IMX6_PCIE_FLAG_HAS_PHYDRV,
15661567
.mode = DW_PCIE_EP_TYPE,
15671568
.gpr = "fsl,imx8mm-iomuxc-gpr",
15681569
.clk_names = imx8mm_clks,
@@ -1573,7 +1574,8 @@ static const struct imx6_pcie_drvdata drvdata[] = {
15731574
},
15741575
[IMX8MP_EP] = {
15751576
.variant = IMX8MP_EP,
1576-
.flags = IMX6_PCIE_FLAG_HAS_PHYDRV,
1577+
.flags = IMX6_PCIE_FLAG_HAS_APP_RESET |
1578+
IMX6_PCIE_FLAG_HAS_PHYDRV,
15771579
.mode = DW_PCIE_EP_TYPE,
15781580
.gpr = "fsl,imx8mp-iomuxc-gpr",
15791581
.clk_names = imx8mm_clks,

0 commit comments

Comments
 (0)