Skip to content

Commit 5264a2f

Browse files
Dan Carpenterrostedt
authored andcommitted
tracing: Fix a NULL vs IS_ERR() bug in event_subsystem_dir()
The eventfs_create_dir() function returns error pointers, it never returns NULL. Update the check to reflect that. Link: https://lore.kernel.org/linux-trace-kernel/ff641474-84e2-46a7-9d7a-62b251a1050c@moroto.mountain Cc: Masami Hiramatsu <mhiramat@kernel.org> Fixes: 5790b1f ("eventfs: Remove eventfs_file and just use eventfs_inode") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent 7e8ad67 commit 5264a2f

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

kernel/trace/trace_events.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2354,7 +2354,7 @@ event_subsystem_dir(struct trace_array *tr, const char *name,
23542354
nr_entries = ARRAY_SIZE(system_entries);
23552355

23562356
ei = eventfs_create_dir(name, parent, system_entries, nr_entries, dir);
2357-
if (!ei) {
2357+
if (IS_ERR(ei)) {
23582358
pr_warn("Failed to create system directory %s\n", name);
23592359
__put_system(system);
23602360
goto out_free;

0 commit comments

Comments
 (0)