Skip to content

Commit 52ca331

Browse files
Uwe Kleine-Königmathieupoirier
authored andcommitted
remoteproc: wkup_m3: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230504194453.1150368-19-u.kleine-koenig@pengutronix.de Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
1 parent 797c4a0 commit 52ca331

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/remoteproc/wkup_m3_rproc.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -223,16 +223,14 @@ static int wkup_m3_rproc_probe(struct platform_device *pdev)
223223
return ret;
224224
}
225225

226-
static int wkup_m3_rproc_remove(struct platform_device *pdev)
226+
static void wkup_m3_rproc_remove(struct platform_device *pdev)
227227
{
228228
struct rproc *rproc = platform_get_drvdata(pdev);
229229

230230
rproc_del(rproc);
231231
rproc_free(rproc);
232232
pm_runtime_put_sync(&pdev->dev);
233233
pm_runtime_disable(&pdev->dev);
234-
235-
return 0;
236234
}
237235

238236
#ifdef CONFIG_PM
@@ -253,7 +251,7 @@ static const struct dev_pm_ops wkup_m3_rproc_pm_ops = {
253251

254252
static struct platform_driver wkup_m3_rproc_driver = {
255253
.probe = wkup_m3_rproc_probe,
256-
.remove = wkup_m3_rproc_remove,
254+
.remove_new = wkup_m3_rproc_remove,
257255
.driver = {
258256
.name = "wkup_m3_rproc",
259257
.of_match_table = wkup_m3_rproc_of_match,

0 commit comments

Comments
 (0)