Skip to content

Commit 53b90bd

Browse files
ColinIanKingdtor
authored andcommitted
Input: ucb1400_ts - remove redundant variable penup
Variable penup is assigned a value but penup is never read later, it is redundant and can be removed. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Link: https://lore.kernel.org/r/20211205000525.153999-1-colin.i.king@gmail.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent 23dee6c commit 53b90bd

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

drivers/input/touchscreen/ucb1400_ts.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,6 @@ static irqreturn_t ucb1400_irq(int irqnr, void *devid)
186186
{
187187
struct ucb1400_ts *ucb = devid;
188188
unsigned int x, y, p;
189-
bool penup;
190189

191190
if (unlikely(irqnr != ucb->irq))
192191
return IRQ_NONE;
@@ -196,8 +195,7 @@ static irqreturn_t ucb1400_irq(int irqnr, void *devid)
196195
/* Start with a small delay before checking pendown state */
197196
msleep(UCB1400_TS_POLL_PERIOD);
198197

199-
while (!ucb->stopped && !(penup = ucb1400_ts_pen_up(ucb))) {
200-
198+
while (!ucb->stopped && !ucb1400_ts_pen_up(ucb)) {
201199
ucb1400_adc_enable(ucb->ac97);
202200
x = ucb1400_ts_read_xpos(ucb);
203201
y = ucb1400_ts_read_ypos(ucb);

0 commit comments

Comments
 (0)